[LLVM][Tests] remove %exeext from lli-child-target parameter. #143077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its presence seems to actively hinder the ToolSubst mechanism that was supposed to fill in the path to the tool, which prevented these tests from working on Cygwin.
|
cc @mstorsjo Given these tests are already expected to fail on Windows otherwise, this was probably just an oversight. Unless there's some other platform that uses %exeext that this might break. This brings llvm test failures on Cygwin from 50 down to 39. |
mstorsjo
approved these changes
Jun 6, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/13078 Here is the relevant piece of the build log for the reference |
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…43077) Its presence seems to actively hinder the ToolSubst mechanism that was supposed to fill in the path to the tool, which prevented these tests from working on Cygwin.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Jul 17, 2025
…43077) Its presence seems to actively hinder the ToolSubst mechanism that was supposed to fill in the path to the tool, which prevented these tests from working on Cygwin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its presence seems to actively hinder the ToolSubst mechanism that was supposed to fill in the path to the tool, which prevented these tests from working on Cygwin.